Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3963: Add FP repro for #6343 #6357

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

costin-zaharia-sonarsource
Copy link
Member

Related to #6343

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I've updated issue title and also PR title a little


public static class TestUtil
{
static TestUtil() // Noncompliant - FP, there are no static fields, see: https://github.com/SonarSource/sonar-dotnet/issues/6343
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To give the issue link higher change for surviving.

Suggested change
static TestUtil() // Noncompliant - FP, there are no static fields, see: https://github.com/SonarSource/sonar-dotnet/issues/6343
// https://github.com/SonarSource/sonar-dotnet/issues/6343
static TestUtil() // Noncompliant - FP, there are no static fields

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit aa1b59d into master Nov 14, 2022
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costin/repro-6343 branch November 14, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants